Elide metadata by default, add --include-util-metadata #4475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new metadata like SRAMDescription is useful, but there are some composition issues with various CIRCT transforms that are not yet resolved. Since this stuff is new (not yet released), I argue we should guard it under a CLI option (
--include-util-metadata
) for the time being. Ultimately, I expect we will want to include it by default, but I think we need the support to mature a bit first.The only metadata at the moment is
SRAMDescription
, but we probably should do similar things withQueue
and possibly other utils so I added a generic CLI option to guard them all.We could also make it possible to elide metadata on an API call by API call basis. I thought about doing that for SRAM but due to the fact that default arguments cause binary compatibility issues, we keep increasing the number of apply methods for SRAM. It's currently 8, adding a new option would up that to 16. If we want to add it as an option for SRAM, I think we need to tweak how that API works, possibly putting some (or all) of the arguments into a class that we carefully maintain compatibility for.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.