Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialize wires for .ref of Aggregate views #4080

Merged
merged 1 commit into from
May 23, 2024
Merged

Materialize wires for .ref of Aggregate views #4080

merged 1 commit into from
May 23, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented May 22, 2024 •
edited
Loading

Fixes #4079. This will result in some wires that may not be necessary which is particularly inelegant for Probes, but it makes certain things work that didn't use to and can be improved further as necessary.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Fix muxing and probing of views of Aggregates

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 5.x milestone May 22, 2024
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label May 22, 2024
@jackkoenig jackkoenig requested a review from dtzSiFive May 22, 2024 20:54
dtzSiFive
dtzSiFive reviewed May 22, 2024
View reviewed changes
Copy link
Member

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Left minor feedback.

src/test/scala/chiselTests/experimental/DataView.scala Outdated Show resolved Hide resolved
src/test/scala/chiselTests/experimental/DataView.scala Outdated Show resolved Hide resolved
@jackkoenig
Materialize wires for .ref of Aggregate views
b4e5cf5 
Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.
@jackkoenig jackkoenig merged commit 5af27e5 into main May 23, 2024
15 checks passed
@jackkoenig jackkoenig deleted the mux-of-views branch May 23, 2024 21:56
@mergify mergify bot added the Backported This PR has been backported label May 23, 2024
mergify bot pushed a commit that referenced this pull request May 23, 2024
@jackkoenig @mergify
Materialize wires for .ref of Aggregate views (#4080)
a7263a0 
Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala
@mergify mergify bot mentioned this pull request May 23, 2024
Merged
14 tasks
mergify bot pushed a commit that referenced this pull request May 23, 2024
@jackkoenig @mergify
Materialize wires for .ref of Aggregate views (#4080)
ac8bb72 
Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)
@mergify mergify bot mentioned this pull request May 23, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request May 23, 2024
@mergify @jackkoenig
Materialize wires for .ref of Aggregate views (#4080) (#4086)
0400ca7 
Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)

Co-authored-by: Jack Koenig <[email protected]>
jackkoenig added a commit that referenced this pull request May 24, 2024
@jackkoenig
Materialize wires for .ref of Aggregate views (#4080)
1b453b7 
Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala
chiselbot pushed a commit that referenced this pull request May 24, 2024
@mergify @jackkoenig
Materialize wires for .ref of Aggregate views (backport #4080) (#4085)
990966c 
* Materialize wires for .ref of Aggregate views (#4080)

Fixes muxing of Aggregate views, and fixes ProbeValues of Aggregate
views.

(cherry picked from commit 5af27e5)

# Conflicts:
#	src/test/scala/chiselTests/experimental/DataView.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive left review comments

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

Mux or ProbeExpr of View doesn't work
3 participants
@jackkoenig @seldridge @dtzSiFive