Add debug unlock procudes in rom #1851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
force-pushed
the
DebugUnlock
branch
2 times, most recently
from
9c26ad0 to
048ef3d
Compare
ArthurHeymans
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
rusty1968,
bluegate010,
ajisaxena and
JohnTraverAmd
as code owners
ArthurHeymans
force-pushed
the
DebugUnlock
branch
from
048ef3d to
7193af2
Compare
Signed-off-by: Arthur Heymans <[email protected]>
Reading the production debug fuses needs this. Signed-off-by: Arthur Heymans <[email protected]>
Signed-off-by: Arthur Heymans <[email protected]>
This adds both the manufactoring and production debug unlock codepaths. There are a few details that need to be resolved in TODOs that are unclear from the documentation. Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
DebugUnlock
branch
from
7193af2 to
967489e
Compare
Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
DebugUnlock
branch
from
967489e to
e863077
Compare
|
I left writing the unit test for production for some later time. I understood the emulator for the Dma engine wrong (it does not operate on the root bus) and it needs to have a completely separate 64bit bus for AXI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs test cases