-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SOC Manifest for Caliptra 2.0 #1797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlvisaya
commented
Nov 16, 2024
- Remove Image Source
- Add Image Identifier
- Add ComponentInfo fields from PLDM
- Add Load Address and Entry point
swenson
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only
mlvisaya
changed the title
[DRAFT] Update SOC Manifest
Update SOC Manifest for Caliptra 2.0
Dec 20, 2024
mlvisaya
force-pushed
the
mlvisaya/doc-update
branch
from
December 20, 2024 21:52
99ad317
to
6c8f416
Compare
- Updated the "Preamble" section to include detailed descriptions of the Version, SVN, Flags, and other fields. - Reformatted field tables for improved readability and consistency. - Added new fields such as IMC Vendor ECC Signature, IMC Vendor LMS Signature, IMC Owner ECC Signature, and IMC Owner LMS Signature. - Expanded "Image Metadata Entry" section with new fields like Image Identifier, Flags, Image Load Address, Classification, Version Number, and Version String. - Revised "Image Metadata Collection" section for clarity and added a new table format.
mlvisaya
force-pushed
the
mlvisaya/doc-update
branch
from
December 20, 2024 22:42
6c8f416
to
074acea
Compare
mhatrevi
reviewed
Dec 21, 2024
mhatrevi
reviewed
Dec 21, 2024
mhatrevi
requested changes
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the feedback.
- remove requirement that images are sorted by image identifier - update number of images supported
mhatrevi
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.