Unify separate FMC and RT SVNs into a single firmware SVN. #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegate010
requested review from
fdamato,
wmaroneAMD,
JohnTraverAmd,
jlmahowa-amd,
korran,
mhatrevi,
swenson,
vsonims,
nquarton,
jhand2,
rusty1968,
FerralCoder and
ajisaxena
as code owners
bluegate010
force-pushed
the
svn-deprecation
branch
from
7769b4a to
d7515c4
Compare
vsonims
requested changes
Nov 2, 2024
bluegate010
changed the title
bluegate010
changed the title
bluegate010
force-pushed
the
svn-deprecation
branch
from
d7515c4 to
c9676ae
Compare
bluegate010
force-pushed
the
svn-deprecation
branch
2 times, most recently
from
60ec50f to
3ee5ce0
Compare
mhatrevi
previously approved these changes
Nov 11, 2024
bluegate010
force-pushed
the
svn-deprecation
branch
from
3ee5ce0 to
e757b77
Compare
mhatrevi
previously approved these changes
Nov 11, 2024
bluegate010
force-pushed
the
svn-deprecation
branch
from
4db3460 to
9797ac9
Compare
jhand2
reviewed
Nov 11, 2024
rom/dev/tests/rom_integration_tests/test_fmcalias_derivation.rs
Outdated
Show resolved
Hide resolved
rom/dev/tests/rom_integration_tests/test_fmcalias_derivation.rs
Outdated
Show resolved
Hide resolved
rom/dev/tests/rom_integration_tests/test_fmcalias_derivation.rs
Outdated
Show resolved
Hide resolved
bluegate010
force-pushed
the
svn-deprecation
branch
5 times, most recently
from
b65e8e0 to
ca0fafc
Compare
|
Update: this will be split into a couple PRs. First PR in #1802 |
bluegate010
force-pushed
the
svn-deprecation
branch
4 times, most recently
from
2057102 to
c83dd35
Compare
- The reported FMC SVN is now called the cold-boot firmware SVN. - Build tooling can no longer set distinct FMC and RT FW SVNs.
bluegate010
force-pushed
the
svn-deprecation
branch
from
c83dd35 to
ec8091b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the size of this PR.
With this change, there is now a singular SVN representing the security state of both FMC and Runtime. This is done as part of enabling Stable Identity in ROM, which can only easily be implemented in terms of a single SVN.
This does not alter the external API for Caliptra, with the sole exception that what was previously reported as the FMC's SVN is now the value of the (FMC+RT) FW SVN as it was during cold-boot.
See additional commentary in #1703.