Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Manifest Based Image Authorization - Runtime commands #1649

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

mhatrevi
Copy link
Collaborator

This change contains the runtime commands, "Set Authorization Manifest" and "Authorize and Stash", for the Manifest Based Image Authorization feature.

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just some nits.

runtime/src/set_auth_manifest.rs Show resolved Hide resolved
runtime/src/set_auth_manifest.rs Outdated Show resolved Hide resolved
runtime/src/set_auth_manifest.rs Outdated Show resolved Hide resolved
runtime/src/set_auth_manifest.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jhand2 jhand2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the first 14 files. I'll pick back up at runtime/src/set_auth_manifest.rs tomorrow.

api/src/mailbox.rs Outdated Show resolved Hide resolved
drivers/src/memory_layout.rs Show resolved Hide resolved
runtime/README.md Outdated Show resolved Hide resolved
runtime/src/authorize_and_stash.rs Outdated Show resolved Hide resolved
runtime/src/authorize_and_stash.rs Show resolved Hide resolved
runtime/src/set_auth_manifest.rs Outdated Show resolved Hide resolved
runtime/README.md Outdated Show resolved Hide resolved
runtime/README.md Outdated Show resolved Hide resolved
swenson
swenson previously approved these changes Sep 3, 2024
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change contains the runtime commands, "Set Authorization Manifest" and "Authorize and Stash", for the Manifest Based Image Authorization feature.
@jhand2 jhand2 force-pushed the vmhatre/man-auth-rt-commands branch from c069896 to a45ebc3 Compare September 3, 2024 23:28
@jhand2 jhand2 enabled auto-merge (squash) September 3, 2024 23:29
@jhand2 jhand2 merged commit 593c9bd into main Sep 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants