-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xtask command to generate and verify flash image #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the flash layout defined in https://github.com/chipsalliance/caliptra-mcu-sw/blob/main/docs/src/flash_layout.md - Add new command to specify the firmware files and soc manifest to create 1 flash image file that can be burned to the SPI flash. - Add new command to verify a flash image file Example: cargo run --bin flash-image create --caliptra-fw caliptra_fw.bin \ --soc-manifest soc_manifest.bin \ --mcu-runtime mcu_runtime.bin \ --soc-images soc_image1.bin soc_image2.bin soc_image3.bin \ --output flash_image.bin cargo run --bin flash-image verify flash_image.bin
mlvisaya
requested review from
swenson,
parvathib,
mhatrevi,
vsonims and
helloxiling
November 21, 2024 19:54
Tests can run simultaneously and can access the same temporary files at the same time.
swenson
reviewed
Nov 21, 2024
Co-authored-by: Christopher Swenson <[email protected]>
- use zerocopy - convert all Vecs in structs to slices - various code optimization
swenson
reviewed
Nov 25, 2024
- use zerocopy to parse image buffer - add packed trait to structs - use String instead of &str in CLI args
swenson
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the flash layout defined in
https://github.com/chipsalliance/caliptra-mcu-sw/blob/main/docs/src/flash_layout.md
Add new command to specify the firmware files and soc manifest to create 1 flash image file that can be burned to the SPI flash.
Add new command to verify a flash image file
Example:
cargo run --bin flash-image create --caliptra-fw caliptra_fw.bin
--soc-manifest soc_manifest.bin
--mcu-runtime mcu_runtime.bin
--soc-images soc_image1.bin soc_image2.bin soc_image3.bin
--output flash_image.bin
cargo run --bin flash-image verify flash_image.bin