Remove redundant casts, use make_uique, use 'using' #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially an auto-repair by clang-tidy .github/bin/run-clang-tidy-cached.cc --checks="-*,readability-redundant-casting" --fix
hzeller
force-pushed
the
feature-20241109-redundant-casts
branch
from
a2d2a6f to
ad50df2
Compare
hzeller
changed the title
Also update the clang-tidy scripts to include the new findings so that we don't backslide.
hzeller
force-pushed
the
feature-20241109-redundant-casts
branch
from
8587f4c to
5577eae
Compare
Instead of = default, this should probably be doing something, but apparently that had been disabled at some point.
hzeller
force-pushed
the
feature-20241109-redundant-casts
branch
9 times, most recently
from
6fe1516 to
e28fcc8
Compare
This way, only changed files have to be re-processed.
hzeller
force-pushed
the
feature-20241109-redundant-casts
branch
from
e28fcc8 to
9fbf9ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially an auto-repair by clang-tidy
.github/bin/run-clang-tidy-cached.cc --checks="-*,readability-redundant-casting" --fix
Similar:
modernize-use-using,modernize-use-nullptr,modernize-make-unique