Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #3862, #3863: Typespec assignment problems #3865

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

hs-apotell
Copy link
Collaborator

Issues #3862, #3863: Typespec assignment problems

  • Handle "returnTypespec" param correctly
  • Set Typespec when handling io_decls
  • Handle packed_array_typespec as well when handling array_tyespec

…oblems

* Handle "returnTypespec" param correctly
* Set Typespec when handling io_decls
* Handle packed_array_typespec as well when handling array_tyespec
@hs-apotell
Copy link
Collaborator Author

@alaindargelas Two tests (CoreSweRV & Opentitan) are reporting one additional error (Unresolved hierarchical path) each. I tried investigating but didn't have much luck. You might have to spend some time investigating this.

@alaindargelas
Copy link
Collaborator

@hs-apotell , something is missing in this PR.
Can you first create a PR in UHDM?

@hs-apotell
Copy link
Collaborator Author

@hs-apotell , something is missing in this PR. Can you first create a PR in UHDM?

Sorry, missed the UHDM PR. Here it is chipsalliance/UHDM#1021

@alaindargelas alaindargelas merged commit 821cb6a into chipsalliance:master Sep 20, 2023
61 checks passed
@alaindargelas
Copy link
Collaborator

@alaindargelas Two tests (CoreSweRV & Opentitan) are reporting one additional error (Unresolved hierarchical path) each. I tried investigating but didn't have much luck. You might have to spend some time investigating this.

The new error is "correct",
it comes from this code:

foreach (pred.m_predecessors[next_pred])

Surelog is not capable of finding the right type for the foreach loop index "pred".

@alaindargelas
Copy link
Collaborator

The message is bad though: [ERR:UH0725] Unresolved hierarchical reference "".
Because the hier_path object has no file, line nor name information.

@hs-apotell
Copy link
Collaborator Author

The message is bad though: [ERR:UH0725] Unresolved hierarchical reference "".

I didn't change anything on how the error gets reported. I can look into it.

@hs-apotell hs-apotell deleted the Issues branch September 20, 2023 05:06
@alaindargelas
Copy link
Collaborator

We would look at the place the hier_path object is built, thats were it's missing the populate data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants