Merge pull request #3912 from alainmarcel/alainmarcel-patch-1

new lint checks
chipsalliance · Oct 19, 2023 · 5060eb6 · 5060eb6
2 parents da30da8 + 7f5b18c
commit 5060eb6
Show file tree

Hide file tree

Showing 14 changed files with 927 additions and 19 deletions.
diff --git a/include/Surelog/ErrorReporting/ErrorDefinition.h b/include/Surelog/ErrorReporting/ErrorDefinition.h
@@ -245,6 +245,7 @@ class ErrorDefinition {
     ELAB_SYSTEM_ERROR = 547,
     ELAB_SYSTEM_WARNING = 548,
     ELAB_SYSTEM_INFO = 549,
+    ELAB_UNKNOWN_PORT = 550,
     LIB_FILE_MAPS_TO_MULTIPLE_LIBS = 600,
     UHDM_UNSUPPORTED_EXPR = 700,
     UHDM_UNSUPPORTED_STMT = 701,
@@ -276,7 +277,8 @@ class ErrorDefinition {
     UHDM_INVALID_CASE_STMT_VALUE = 727,
     UHDM_UNSUPPORTED_TYPESPEC = 728,
     UHDM_UNRESOLVED_PROPERTY = 729,
-    UHDM_NON_TEMPORAL_SEQUENCE_USE = 730
+    UHDM_NON_TEMPORAL_SEQUENCE_USE = 730,
+    UHDM_NON_POSITIVE_VALUE = 731
   };
 
   class ErrorInfo {

diff --git a/src/DesignCompile/NetlistElaboration.cpp b/src/DesignCompile/NetlistElaboration.cpp
@@ -807,9 +807,11 @@ bool NetlistElaboration::high_conn_(ModuleInstance* instance) {
     signals = &comp->getPorts();
   }
   std::map<std::string_view, Signal*> allSignals;
+  std::map<std::string_view, Signal*> allSignalsConst;
   if (signals) {
     for (Signal* s : *signals) {
       allSignals.emplace(s->getName(), s);
+      allSignalsConst.emplace(s->getName(), s);
     }
   }
   if ((inst_type == VObjectType::paUdp_instantiation) ||
@@ -1178,6 +1180,24 @@ bool NetlistElaboration::high_conn_(ModuleInstance* instance) {
                   p = s.MakePort();
                   ports->push_back(p);
                   p->VpiName(formalName);
+                  fC->populateCoreMembers(formalId, formalId, p);
+                  if (!allSignalsConst.empty()) {
+                    auto found = allSignalsConst.find(p->VpiName());
+                    if (found == allSignalsConst.end()) {
+                      SymbolTable* symbols =
+                          m_compileDesign->getCompiler()->getSymbolTable();
+                      ErrorContainer* errors =
+                          m_compileDesign->getCompiler()->getErrorContainer();
+                      Location loc(
+                          fileSystem->toPathId(
+                              p->VpiFile(),
+                              m_compileDesign->getCompiler()->getSymbolTable()),
+                          p->VpiLineNo(), p->VpiColumnNo(),
+                          symbols->registerSymbol(p->VpiName()));
+                      Error err(ErrorDefinition::ELAB_UNKNOWN_PORT, loc);
+                      errors->addError(err);
+                    }
+                  }
                 }
               } else {
                 ports = s.MakePortVec();
@@ -1198,6 +1218,20 @@ bool NetlistElaboration::high_conn_(ModuleInstance* instance) {
                        VObjectType::paExpression) {  // .p(s) connection by name
               sigId = tmp;
               Expression = tmp;
+              if (!allSignalsConst.empty()) {
+                auto found = allSignalsConst.find(formalName);
+                if (found == allSignalsConst.end()) {
+                  SymbolTable* symbols =
+                      m_compileDesign->getCompiler()->getSymbolTable();
+                  ErrorContainer* errors =
+                      m_compileDesign->getCompiler()->getErrorContainer();
+                  Location loc(fC->getFileId(formalId), fC->Line(formalId),
+                               fC->Column(formalId),
+                               symbols->registerSymbol(formalName));
+                  Error err(ErrorDefinition::ELAB_UNKNOWN_PORT, loc);
+                  errors->addError(err);
+                }
+              }
             }
           }  // else .p implicit connection
         }

diff --git a/src/ErrorReporting/ErrorDefinition.cpp b/src/ErrorReporting/ErrorDefinition.cpp
@@ -426,6 +426,7 @@ bool ErrorDefinition::init() {
       "Skipping blackboxed instance \"%s\"");
   rec(ELAB_INVALID_CASE_STMT_VALUE, ERROR, ELAB,
       "Invalid generate case stmt value");
+  rec(ELAB_UNKNOWN_PORT, ERROR, ELAB, "Unknown port \"%s\"");
   rec(ELAB_SYSTEM_FATAL, FATAL, ELAB, "Fatal elaboration %s");
   rec(ELAB_SYSTEM_ERROR, ERROR, ELAB, "Elaboration error %s");
   rec(ELAB_SYSTEM_WARNING, WARNING, ELAB, "Elaboration warning %s");
@@ -477,6 +478,8 @@ bool ErrorDefinition::init() {
   rec(UHDM_UNRESOLVED_PROPERTY, ERROR, UHDM, "Unresolved property \"%s\"");
   rec(UHDM_NON_TEMPORAL_SEQUENCE_USE, ERROR, UHDM,
       "Sequence used in non-temporal context \"%s\"");
+  rec(UHDM_NON_POSITIVE_VALUE, ERROR, UHDM,
+      "Required positive value (>=1), \"%s\" given");
   return true;
 }