yarn upgrade @types/http-proxy #1023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @antiBaconMachine for improving Included your update in: #1026 Instead of updating the lock file; I've updated the patch version to make sure consumers will get the latest patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently I noticed that the
methodoption was missing from the http-proxy serverOptions type. I've submitted a patch for the type DefinitelyTyped/DefinitelyTyped#70173, this PR simply bumps the dependency version for the type so we can use it with this module.How has this been tested?
The functionality already worked as options are just passed through to http-proxy. It just caused a typescript error. We no longer get typescript errors.
Types of changes
Checklist: