Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix circular dependencies #1010

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

chimurai
Copy link
Owner

@chimurai chimurai commented Jun 4, 2024

fixes #1007

npx madge --circular src/index.ts

Before:
image

After:
image

@coveralls
Copy link

Coverage Status

coverage: 97.686% (+0.006%) from 97.68%
when pulling 66e3217 on fix-circular-dependencies
into 82aaf0a on master.

@chimurai chimurai force-pushed the fix-circular-dependencies branch from 66e3217 to bb48375 Compare June 4, 2024 19:39
@coveralls
Copy link

Coverage Status

coverage: 97.686% (+0.006%) from 97.68%
when pulling bb48375 on fix-circular-dependencies
into 82aaf0a on master.

@chimurai chimurai merged commit 520ffd7 into master Jun 8, 2024
17 checks passed
@chimurai chimurai deleted the fix-circular-dependencies branch June 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency of build
2 participants