Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow exclude by buftypes #101

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

ofseed
Copy link
Contributor

@ofseed ofseed commented Jan 3, 2024

Close #72

There are too many file types that need to be ignored, there are file types I ignored:

https://github.com/ofseed/nvim/blob/f3388dd77834c2d361e03296afbf617a86b147a4/lua/plugins/ui/marks.lua#L21-L48

But if we can ignore it by buftypes, that would be much easier, I only need to ignore nofile buftype.

@ofseed
Copy link
Contributor Author

ofseed commented Jan 3, 2024

What made me create this PR is, in neovim, floating windows do not respect the signcolumn users set, they must be signcolumn=auto by default, which causes marks.nvim place signs in these floating windows. For some floating windows with a common filetype like markdown, it is not possible to ignore them by filetypes.

@chentoast
Copy link
Owner

LGTM. Thanks for the PR!

@chentoast chentoast merged commit 74e8d01 into chentoast:master Jan 7, 2024
1 check passed
kamack38 pushed a commit to kamack38/marks.nvim that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to Ignore all buffers with buftype nofile?
2 participants