Gui: Fix crash in DlgSettingsLightSources

Fixes FreeCAD#13357
chennes · Aug 9, 2024 · 362cf1c · 362cf1c
1 parent 8339bd9
commit 362cf1c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/Gui/PreferencePages/DlgSettingsLightSources.cpp b/src/Gui/PreferencePages/DlgSettingsLightSources.cpp
@@ -57,7 +57,6 @@ DlgSettingsLightSources::DlgSettingsLightSources(QWidget* parent)
 
 DlgSettingsLightSources::~DlgSettingsLightSources()
 {
-    delete view;
 }
 
 void DlgSettingsLightSources::setupConnection()
@@ -73,14 +72,16 @@ void DlgSettingsLightSources::setupConnection()
 void DlgSettingsLightSources::showEvent(QShowEvent* event)
 {
     Q_UNUSED(event)
-    if (!view) {
+    static bool underConstruction = false;  // Prevent recursion
+    if (!underConstruction && !view) {
+        underConstruction = true;
         QGroupBox* box = ui->groupBoxLight;
         QWidget* widget = createViewer(box);
         auto grid = new QGridLayout(box);
         grid->addWidget(widget);
-        box->setLayout(grid);
 
         loadDirection();
+        underConstruction = false;
     }
 }