Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Python 3.10 support #216

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sven-ruess
Copy link
Contributor

  • Added a dev container for testing, if it is running with Python 3.10.X
    • Container is only used for running library_test.py
    • git and local tests are not configured and usable
  • Updated poetry.lock
  • Added Python 3.10 in github CI
  • Allowed Python 3.10 in pyproject.toml

Dev Container Python 3.12 is used for git and running local tests.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@38b02d9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #216   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?        14           
  Branches        ?         0           
========================================
  Hits            ?        14           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chemelli74
Copy link
Owner

Hi @sven-ruess , while I agreed on re-adding 3.11, I think that 3.10 is not worth.

@sven-ruess
Copy link
Contributor Author

I agree to you. I do not want to add it. But two customers found the information, that I doing some coding here and they asked why? I told them, that this library will be the base for monitoring Vodafone Stations. With that information, they requested me to support it for them, too.
The problem is, that they were running old software versions. The plan is to do the upgrade in autumn next year. Until this I need support for Python 3.10.

Changes for Python 3.10 are very small. They can be reverted at the end of next year. I can set a reminder for me to drop Python 3.10 support until software is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants