add doc changes for feature flag and gtm_id #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayush-billore <[email protected]>
ayush-billore
force-pushed
the
gdpr-documentation
branch
from
05c7d60 to
a9c2da5
Compare
Signed-off-by: Ian Maddaus <[email protected]>
IanMadd
reviewed
Dec 13, 2023
|
|
||
| `default['supermarket']['google_analytics_id']` | ||
|
|
||
| : The Google Analytics [tracking ID](https://support.google.com/analytics/answer/7372977?hl=en) for Supermarket. Default value: `nil`. | ||
| : The Google Analytics [tracking ID](https://support.google.com/analytics/answer/7372977?hl=en) for Supermarket. |
There was a problem hiding this comment.
Is this URL correct? It links to the deprecated Universal Analytics docs.
There was a problem hiding this comment.
I have not updated this URL, It was already present in the codebase.
We can consider adding https://support.google.com/analytics/answer/9539598?hl=en if it looks good to you.
…e values in string format Signed-off-by: ayush-billore <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
Signed-off-by: Ian Maddaus <[email protected]>
|
|
@IanMadd , can you please approve this PR, if there is nothing pending on this? |
IanMadd
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation changes for following feature flags
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List