Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for supermarket configuration with Chef Identity #3161

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

RoyShravani
Copy link
Contributor

@RoyShravani RoyShravani commented Sep 21, 2023

Description

As part of the oc-id upgrade, it was found that one of the main gem Doorkeeper has two security vulnerability issues:

  • CVE-2018-1000211
  • CVE-2020-10187
    Consequentially, doorkeeper gem has been upgraded from version 4.3 to use 5+. As a part of the doorkeeper upgrade, there has been few updates in the authorization of applications such as Supermarket with oc-id or Chef-Identity.

Issues Resolved

This PR aims to update install_supermarket.md file to reflect the addition of a new field confidential to the supermarket config file for Chef Infra Server versions 15.8.x
Retrieval of Supermarket's OAuth 2.0 client credentials will the return this config along with this new confidential field.

Check List

@RoyShravani RoyShravani requested a review from a team as a code owner September 21, 2023 07:22
@RoyShravani RoyShravani marked this pull request as draft September 21, 2023 07:22
@github-actions github-actions bot added the Documentation Gets work onto the docs board label Sep 21, 2023
@RoyShravani RoyShravani marked this pull request as ready for review September 21, 2023 10:48
```javascript
{
"name": "supermarket",
"uid": "0bad0f2eb04e935718e081fb71asdfec3681c81acb9968a8e1e32451d08b",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change uid and secret values with *****

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Signed-off-by: Ian Maddaus <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saghoshprogress saghoshprogress merged commit a54ceee into main Oct 4, 2023
16 of 17 checks passed
@saghoshprogress saghoshprogress deleted the CHEF-5595 branch October 4, 2023 14:12
@RoyShravani RoyShravani changed the title Update doc for supermarket configuration with Chef Identity CHEF-5995 Update doc for supermarket configuration with Chef Identity Oct 25, 2023
@RoyShravani RoyShravani changed the title CHEF-5995 Update doc for supermarket configuration with Chef Identity Update doc for supermarket configuration with Chef Identity Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Gets work onto the docs board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants