Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for versions of ruby prior to 2.6 #381

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcparadise
Copy link
Member

Ruby 2.5 and earlier are all EOL and are no longer receiving security updates.

Signed-off-by: Marc A. Paradise [email protected]

@marcparadise
Copy link
Member Author

Note that windows build was failing prior to this PR, and is not addressed here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marcparadise
Copy link
Member Author

Will update this further - even though we can't test these older versions, there may still be cases where they get pulled in and will work (like chef-install cookbook for upgrades). After update, it will leave in 'soft' support (conditional gems by version) but remove the unsupported ruby versions.

@jaymzh jaymzh added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Nov 1, 2022
@jaymzh
Copy link
Collaborator

jaymzh commented Nov 1, 2022

@marcparadise ping? :)

@tpowell-progress tpowell-progress self-assigned this Apr 25, 2023
Ruby 2.5 and earlier are all EOL and are no longer receiving security
updates.

Signed-off-by: Marc A. Paradise <[email protected]>
pry-byebug is not supported on all platforms, and is also not necessary
for running pipeline tests. Excluding gem group 'debug' from tests prevents
failures related to unsupported platforms.

Signed-off-by: Marc A. Paradise <[email protected]>
Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress requested a review from a team as a code owner October 31, 2023 17:49
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jaymzh
Copy link
Collaborator

jaymzh commented Oct 29, 2024

This relates to: #400

@marcparadise - I'm unclear on the status of this PR - I think we can merge, but it's been 2 years, so we should at least rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants