Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ruby 3.3 pipeline #525

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −7
Open

Added the ruby 3.3 pipeline #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d8ba95
added ruby 3.3 pipeline
nikhil2611 Jun 19, 2024
3e0db73
added windows ruby 3.3 verify pipeline
nikhil2611 Jul 4, 2024
34291c2
testing the ruby 3.3 error
nikhil2611 Jul 5, 2024
3c8d90f
updated ruby 3.3 pipeline
nikhil2611 Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .expeditor/verify.pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ expeditor:

steps:

- label: run-lint-and-specs-ruby-3.1
- label: run-lint-and-specs-ruby-3.3
command:
- .expeditor/run_linux_tests.sh rake
expeditor:
executor:
docker:
image: ruby:3.1-buster
- label: run-lint-and-specs-windows
image: ruby:3.3
- label: run-lint-and-specs-windows-3.3
command:
- gem install chef-utils
- bundle install --jobs=7 --retry=3
Expand All @@ -27,4 +27,4 @@ steps:
executor:
docker:
host_os: windows
image: rubydistros/windows-2019:3.1
image: rubydistros/windows-2019:3.3
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if ENV["GEMFILE_MOD"]
puts "GEMFILE_MOD: #{ENV["GEMFILE_MOD"]}"
instance_eval(ENV["GEMFILE_MOD"])
else
gem "ohai", git: "https://github.com/chef/ohai", branch: "main"
gem "ohai", "~> 18.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 18-stable

gem "knife"
end

Expand Down
4 changes: 2 additions & 2 deletions knife-windows.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ Gem::Specification.new do |s|
s.summary = %q{Plugin that adds functionality to Chef Infra's Knife CLI for configuring/interacting with nodes running Microsoft Windows}
s.description = s.summary

s.required_ruby_version = ">= 3.1"
s.add_dependency "chef", ">= 18.2"
s.required_ruby_version = ">= 3.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't update this to 3.3 as it then wont be able to support chef-18. This does not control what version of ruby this works with other than setting a minimum version of ruby. Unless there is a breaking change or we are bumping for limiting versions we support this shouldn't get bumped up then. The ruby version installed on the system determines which ruby version this is working with. Expeditor is where you'd define the ruby version to run and test this on. @tpowell-progress can help explain this more if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @Stromweld we wont we merging these PRs now, these pr's will be merged after ruby 3.3 upgrade in chef-client and inspec.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the end this isn't needed for that. >= 3.1 sets minimum ruby version for this gem, unless there is a reason to need to bump the minimum version such as a change that is only in a newer version it doesn't make sense to update the required_ruby_version as it'll create compatibility problems for chef 18 and older versions that are not running on ruby 3.3 but will still need to be supported.

Copy link
Contributor Author

@nikhil2611 nikhil2611 Jul 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay but ruby 3.1 will be going end of life by 2025-03-31, should we still keep that ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say yes since chef-client 18.x wont be EOL by then. Unless there are code changes that take advantage of newer ruby version changes that make it not backwards compatible with older ruby version then this value really doesn't need to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine that we will likely keep Ruby 3.1 in place for the foreseeable future, despite official EOL. I would in general be as conservative as possible with minimum Ruby requirements to avoid unnecessary headaches. Ruby 3.0 introduces some Ruby API changes that are sensible to require, but I would hesitate be too much higher than that. Considering this is updates going forward, Ruby 3.1 is understandable.

s.add_dependency "chef", "~> 18.0"
s.add_dependency "winrm", "~> 2.1"
s.add_dependency "winrm-elevated", "~> 1.0"

Expand Down
Loading