Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef 17 #524

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Chef 17 #524

wants to merge 7 commits into from
+7 −6

Conversation

johnmccrae
Copy link
Contributor

Description

Creating a specific chef-17 branch. The existing code base was pulling in Chef-18 gems and failing testing because of the mixed Ruby versions

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested review from a team as code owners April 25, 2023 23:20
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqube-for-infrastructure-prod
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

neha-p6 and others added 3 commits August 9, 2024 20:11
@neha-p6
Add dependency to pin rexml at <= 3.3.1 as latest versions throw exec…
9de47cd 
…ption when parsing invalid xml. Without the ping latest gem gets pulled in.

Signed-off-by: Neha Pansare <[email protected]>
@neha-p6
Revert "Add dependency to pin rexml at <= 3.3.1 as latest versions th…
25bdf25 
…row execption when parsing invalid xml. Without the ping latest gem gets pulled in."

This reverts commit 9de47cd.
@johnmccrae
Updating rxml dependency (#529)
b6b01c2 
Signed-off-by: John McCrae <[email protected]>
@sonarqube-for-infrastructure-prod SonarQube for Infrastructure (Prod)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmccrae @neha-p6