Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby upgrade to 3.3 #25

Closed
wants to merge 1 commit into from
Closed

Ruby upgrade to 3.3 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu, macos, windows]
ruby: [2.7, 3.0, 3.1]
ruby: [3.3]
steps:
- run: |
if [ "$RUNNER_OS" == "Linux" ]; then
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ group :development do
gem "webmock", ">= 1.11"
gem "http", ">= 0.9.8"
gem "chefstyle"
gem "graphviz", "~> 1.2"
end

instance_eval(ENV["GEMFILE_MOD"]) if ENV["GEMFILE_MOD"]
Expand Down
8 changes: 4 additions & 4 deletions berkshelf.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |s|
s.name = "berkshelf"
s.require_paths = ["lib"]
s.version = Berkshelf::VERSION
s.required_ruby_version = ">= 2.7.0"
s.required_ruby_version = ">= 3.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break everything that depends on it. ">= 3.0" is the best we can do.

s.required_rubygems_version = ">= 2.0.0"
s.metadata = {
"bug_tracker_uri" => "https://github.com/chef/berkshelf/issues",
Expand All @@ -42,9 +42,9 @@ Gem::Specification.new do |s|
s.add_dependency "octokit", "~> 4.0"
s.add_dependency "mixlib-archive", ">= 1.1.4", "< 2.0" # needed for ruby 3.0 / Dir.chdir removal
s.add_dependency "concurrent-ruby", "~> 1.0"
if RUBY_VERSION.match?(/3.0/)
s.add_dependency "chef", "~> 17.0" # needed for --skip-syntax-check
elsif
if RUBY_VERSION.match?(/3.3/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chef 18 and 3.3 are by definition not going to be paired together unless installed as a gem. Chef 18 supports Ruby 3.0 for AIX and Ruby 3.1 for other platforms.

s.add_dependency "chef", "~> 18.0" # needed for --skip-syntax-check
else
s.add_dependency "chef", ">= 15.7.32"
end
s.add_dependency "chef-config"
Expand Down
Loading