This resolves an issue where "berks install" fails due to a cert is already being in the hash table. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch. Signed-off-by: nikhil2611 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarQube Quality Gate
|
ashiqueps
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves an issue where "berks install" fails due to a cert is already being in the hash table. The error is being accidentally raised because the message string does not match exactly what is stored in e.message.
We tweaked the error handler to be a regex match versus a strict text match.
Instead if using
e.message == "cert already in hash table"we can use a regular expression instead like this:e.message.match(/cert already in hash table/)Issues Resolved
https://chefio.atlassian.net/browse/CHEF-3994
Check List