Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermarket 4.0 #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Supermarket 4.0 #76

wants to merge 2 commits into from

Conversation

kagarmoe
Copy link

@kagarmoe kagarmoe commented Dec 30, 2021

Signed-off-by: kagarmoe [email protected]

Description

As a Private Supermarket user, I should be confident that this cookbook is maintained.

This PR:

  • Changes SEMVER to 4.0--the same major release number as the chef.io/downloads package
  • Changes the maintainer to Chef Software, Inc.
  • Changes the email to the Chef cookbooks email
  • Updates the minimum Chef version to 16.0

Obviously, the change of maintainers is up to @irvingpop.

I need somebody else to trigger the tests.

Issues Resolved

Check List

kagarmoe added 2 commits December 30, 2021 15:08
Signed-off-by: kagarmoe <[email protected]>
Signed-off-by: kagarmoe <[email protected]>
@kagarmoe kagarmoe requested review from a team December 30, 2021 23:23
Copy link

@irvingpop irvingpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this up to date @kagarmoe ! If you want to remove my name from the Author credit in the README that's fine as well. I feel like there's some kind of statute of limitations for when an absentee maintainer should give up author credit :)

Copy link
Member

@xorima xorima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get the unified_mode settings added to the resources at the same time if we are going to minimum chef 16 and a major release?

@kagarmoe
Copy link
Author

Could someone either merge this or close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants