Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings for CHEF-19 #3

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Fix deprecation warnings for CHEF-19 #3

merged 1 commit into from
Mar 2, 2018

Conversation

gordonbondon
Copy link

@gordonbondon gordonbondon commented Mar 2, 2018 •
edited
Loading

Chef was complaining about using name property directly:

[2018-03-02T10:05:38+00:00] ERROR: zfs[testpool/setprop] (test::default line 66) had an error: Chef::Exceptions::DeprecatedFeatureError: "rename name to new_resource.name (CHEF-19)/tmp/kitchen/cache/cookbooks/chef_zfs/resources/default.rb:29:in `block in class_from_file'.\nPlease see https://docs.chef.io/deprecations_namespace_collisions.html for further details and information on how to correct this problem. at /opt/chef/embedded/lib/ruby/gems/2.4.0/gems/chef-13.8.0/lib/chef/formatters/doc.rb:419:in `deprecation'"

This PR should fix it. Plus I've added warn log_level to kitchen to help catch deprecations.

@tas50 tas50 merged commit 31b96c3 into chef-cookbooks:master Mar 2, 2018
@tas50
Copy link

tas50 commented Mar 2, 2018

Nice catch. Thanks

@gordonbondon gordonbondon deleted the gordonbondon/fix_name_deprecation branch March 5, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gordonbondon @tas50