Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memfd: test fd-sharing for memfds #2237

Closed

Conversation

osctobe
Copy link
Contributor

@osctobe osctobe commented Aug 4, 2023

Add a test that verifies that memfd's are properly unshared to validate incoming executable-memfd fix.

@osctobe osctobe marked this pull request as draft August 4, 2023 14:02
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (1db922f) 70.69% compared to head (4344a84) 70.67%.

❗ Current head 4344a84 differs from pull request most recent head f1bc1b0. Consider uploading reports for the commit f1bc1b0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2237      +/-   ##
============================================
- Coverage     70.69%   70.67%   -0.02%     
============================================
  Files           133      133              
  Lines         33319    33319              
============================================
- Hits          23555    23549       -6     
- Misses         9764     9770       +6     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michał Mirosław <[email protected]>
@osctobe osctobe closed this Aug 21, 2023
@osctobe osctobe deleted the test-memfd-sharing branch August 21, 2023 14:00
@avagin
Copy link
Member

avagin commented Aug 21, 2023

@osctobe why do you decide to close this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants