kerndat: Skip clone3(set_tid) when unprivileged.

clone3(set_tid) requires CAP_CHECKPOINT_RESTORE we might not have. Assume that if it errored out with EPERM it's there and might be usable from inside a user namespace. Change-Id: I3ef5ab98ba1baac1e0b0202b04518ad2b2fea2b1 Signed-off-by: Michał Mirosław <[email protected]>
checkpoint-restore · Nov 14, 2023 · d8d18f7 · d8d18f7
1 parent c474816
commit d8d18f7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/criu/kerndat.c b/criu/kerndat.c
@@ -1400,12 +1400,13 @@ static bool kerndat_has_clone3_set_tid(void)
 	pid_t pid;
 	struct _clone_args args = {};
 
+	kdat.has_clone3_set_tid = false;
+
 #if defined(CONFIG_MIPS)
 	/*
 	 * Currently the CRIU PIE assembler clone3() wrapper is
 	 * not implemented for MIPS.
 	 */
-	kdat.has_clone3_set_tid = false;
 	return 0;
 #endif
 
@@ -1427,7 +1428,7 @@ static bool kerndat_has_clone3_set_tid(void)
 	if (errno == ENOSYS || errno == E2BIG)
 		return 0;
 
-	if (errno != EINVAL) {
+	if (errno != EINVAL && errno != EPERM) {
 		pr_pwarn("Unexpected error from clone3");
 		return 0;
 	}