Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages #278

Conversation

fabio-insolia-cko
Copy link
Contributor

@fabio-insolia-cko fabio-insolia-cko commented Jun 26, 2024

Issue

PIMOB-2639

Proposed changes

Added BidiFormatter to handle RTL languages for phone number

Test Steps

BEFORE THE FIX

PIMOB-2639.before.mp4
  1. Open the sample app with the prefillData (as per requirement)
  2. Open the device settings and set the device Language to any RTL language (in the video above is Arabic)
  3. Reopen the app and verify that the phone is displayed correctly

AFTER THE FIX

PIMOB-2639.mp4

Checklist

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Copy link

@fabio-insolia-cko fabio-insolia-cko merged commit 2daba11 into master Jun 26, 2024
23 checks passed
@fabio-insolia-cko fabio-insolia-cko deleted the feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages branch June 26, 2024 13:04
@fabio-insolia-cko fabio-insolia-cko restored the feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages branch June 26, 2024 13:04
@fabio-insolia-cko fabio-insolia-cko deleted the feature/PIMOB-2639_Fix_for_phone_numeber_on_RTL_languages branch June 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants