Fix: Await risk sdk actions #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precious-ossai-cko
changed the title
precious-ossai-cko
force-pushed
the
fix/await-risk-sdk-actions
branch
2 times, most recently
from
3c95601 to
a21944a
Compare
precious-ossai-cko
force-pushed
the
fix/await-risk-sdk-actions
branch
from
a21944a to
1592d3a
Compare
checkout/src/test/java/com/checkout/tokenization/repository/TokenRepositoryImplTest.kt
Outdated
Show resolved
Hide resolved
checkout/src/test/java/com/checkout/tokenization/repository/TokenRepositoryImplTest.kt
Outdated
Show resolved
Hide resolved
checkout/src/main/java/com/checkout/tokenization/repository/TokenRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
checkout/src/main/java/com/checkout/tokenization/repository/TokenRepositoryImpl.kt
Show resolved
Hide resolved
checkout/src/test/java/com/checkout/tokenization/repository/TokenRepositoryImplTest.kt
Outdated
Show resolved
Hide resolved
checkout/src/main/java/com/checkout/tokenization/repository/TokenRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
checkout/src/test/java/com/checkout/tokenization/repository/TokenRepositoryImplTest.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the changes. Have we done any manual tests? If so let's rebase and merge this branch |
jheng-hao-lin-cko
previously approved these changes
Jun 10, 2024
precious-ossai-cko
force-pushed
the
fix/await-risk-sdk-actions
branch
from
777e6f6 to
566f94e
Compare
- internally improves log instrumentation
precious-ossai-cko
force-pushed
the
fix/await-risk-sdk-actions
branch
from
c240451 to
b32ae6c
Compare
|
fabio-insolia-cko
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://checkout.atlassian.net/browse/PRISM-11245
Proposed changes
Await acitons on the Risk SDK before continuing.
Test Steps
No changes in interaction or operation or test order.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NB: Regardless of success or failure within Risk, the completion handler is called on both scenarios.
NB: All asynchronous actions have a maximum timeout of 5 seconds.