Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/PIMOB-2217_Integrate_slack_message #253

Merged
merged 13 commits into from
Nov 15, 2023
Merged

feature/PIMOB-2217_Integrate_slack_message #253

merged 13 commits into from
Nov 15, 2023

Conversation

fabio-insolia-cko
Copy link
Contributor

@fabio-insolia-cko fabio-insolia-cko commented Nov 13, 2023 •
edited
Loading

Issue

PIMOB-2217

Proposed changes

Add a Slack integration depends on the build result.
Screenshot 2023-11-14 at 17 38 45

Test Steps

  • Each Slack msg will display a link for the github action page
  • Each Slack msg will display a link for the github PR
  • Each Slack msg will display the author of the PR
  • Make expected failed build PR, it should send a Slack msg to #android-builds and says where it fails.
  • Make expected successful build PR, it should send a Slack msg to #android-builds and says where it succeeded.

Checklist

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc...

@fabio-insolia-cko fabio-insolia-cko self-assigned this Nov 13, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fabio-insolia-cko fabio-insolia-cko marked this pull request as ready for review November 14, 2023 17:39
@fabio-insolia-cko fabio-insolia-cko requested a review from a team as a code owner November 14, 2023 17:39
@fabio-insolia-cko fabio-insolia-cko merged commit 442014a into master Nov 15, 2023
5 of 6 checks passed
@fabio-insolia-cko fabio-insolia-cko deleted the feature/PIMOB-2217_Integrate_slack_message branch November 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chintan-soni-cko chintan-soni-cko chintan-soni-cko approved these changes

Assignees

@fabio-insolia-cko fabio-insolia-cko

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabio-insolia-cko @chintan-soni-cko @jheng-hao-lin-cko