Update DNS Merchant regular expression length (#414)

checkout · Aug 29, 2024 · c34be15 · c34be15
1 parent d82d31a
commit c34be15
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/CheckoutSdk/Environment.cs b/src/CheckoutSdk/Environment.cs
@@ -35,7 +35,7 @@ private static Uri AddSubdomainToApiUrlEnvironment(Environment environment, stri
 
             Uri newEnvironment = new Uri(apiUrl.ToString());
 
-            Regex regex = new Regex(@"^[0-9a-z]{8,11}$");
+            Regex regex = new Regex(@"^[0-9a-z]+$");
             if (regex.IsMatch(subdomain))
             {
                 UriBuilder merchantApiUrl = new UriBuilder(apiUrl.Host);

diff --git a/test/CheckoutSdkTest/CheckoutConfigurationTest.cs b/test/CheckoutSdkTest/CheckoutConfigurationTest.cs
@@ -19,9 +19,10 @@ private void ShouldCreateConfiguration()
         }
 
         [Theory]
-        [InlineData("123dmain", "https://123dmain.api.sandbox.checkout.com/")]
-        [InlineData("123domain", "https://123domain.api.sandbox.checkout.com/")]
-        [InlineData("1234domain", "https://1234domain.api.sandbox.checkout.com/")]
+        [InlineData("a", "https://a.api.sandbox.checkout.com/")]
+        [InlineData("ab", "https://ab.api.sandbox.checkout.com/")]
+        [InlineData("abc", "https://abc.api.sandbox.checkout.com/")]
+        [InlineData("abc1", "https://abc1.api.sandbox.checkout.com/")]
         [InlineData("12345domain", "https://12345domain.api.sandbox.checkout.com/")]
         public void ShouldCreateConfigurationWithSubdomain(string subdomain, string expectedUri)
         {
@@ -38,9 +39,11 @@ public void ShouldCreateConfigurationWithSubdomain(string subdomain, string expe
 
         [Theory]
         [InlineData("", "https://api.sandbox.checkout.com/")]
-        [InlineData("123", "https://api.sandbox.checkout.com/")]
-        [InlineData("123bad", "https://api.sandbox.checkout.com/")]
-        [InlineData("12345domainBad", "https://api.sandbox.checkout.com/")]
+        [InlineData(" ", "https://api.sandbox.checkout.com/")]
+        [InlineData("  ", "https://api.sandbox.checkout.com/")]
+        [InlineData(" - ", "https://api.sandbox.checkout.com/")]
+        [InlineData("a b", "https://api.sandbox.checkout.com/")]
+        [InlineData("ab c1", "https://api.sandbox.checkout.com/")]
         public void ShouldCreateConfigurationWithBadSubdomain(string subdomain, string expectedUri)
         {
             var credentials = new StaticKeysSdkCredentials(ValidDefaultSk, ValidDefaultPk);