Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Windows CI runs #1207

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Fixes for Windows CI runs #1207

merged 4 commits into from
Sep 24, 2024

Conversation

dtarditi
Copy link
Member

These changes fix the Windows CI runs when using GitHub's "windows-latest" runners. They go with this PR in the workflows repo.

  • Disable 2 failing clang tests for CUDA features. There is a Windows configuration specific issue that I don't want to spend time tracking down. The tests work fine on my Windows machine and break on GitHub's CI runner.
  • GitHub's Windows latest no longer includes Python's distutil package for Python 3.10, even though it wasn't removed until Python 3.12. Switch over to the recommended shutil package.
  • Work around a bug in shutil for Python 3.10 on Windows where it sometimes ignores the shell variable for executable file extensions. This caues the which function to not find clang, because the actual file name on Windows is clang.exe.

@dtarditi
Replace use of find_executable in Python scripts
cb80f53 
The distutils package is deprecated and may not be always
be present.  Follow the recommendation in PEP 632 to
replace find_executable with shutil.which.
@dtarditi
Remove unnecessary use of distutils.spawn in the update_cc_test_check…
7f11124 
…s script.
@dtarditi
Replace use of distutils, which has been deprecated.
a3ac5cd
@dtarditi
Disable some tests that work locally on Windows and fail on the GitHu…
f3b69bc 
…b CI runner.
@dtarditi dtarditi requested review from Machiry and souragc September 16, 2024 06:51
@Machiry Machiry added the CI Changes Changes to make CI Happy label Sep 23, 2024
@Machiry Machiry self-assigned this Sep 23, 2024
Machiry
Machiry approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Machiry Machiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have added a label for CI related changes --- making it easy to track.

@dtarditi dtarditi merged commit a2843ea into main Sep 24, 2024
@dtarditi dtarditi deleted the workflow-issue-1 branch September 24, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machiry Machiry Machiry approved these changes

@souragc souragc Awaiting requested review from souragc

Assignees

@Machiry Machiry

Labels
CI Changes Changes to make CI Happy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtarditi @Machiry