made changes to incorporate an option for adding labels to the docker image #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmunday3
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Approving these changes with the intention to go back and further modify full_workflow_build.py to include all optional metadata and build options.
Additional "full workflow" components will include:
metadata.model_authormetadata.technicalmetadata.performancemetadata.summarymetadata.detailsmetadata.batch_sizemetadata.num_cpusmetadata.num_gpusmetadata.required_rammetadata.run_timeoutmetadata.status_timeout- Additional parameters in
BuildOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updates to buildable, options, Dockerfile, and full_workflow_build that all a user to specify a dictionary of key value pairs that are then added as Labels to the Docker image when it is created.