-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrange plugins by type #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @simonbrunel was against putting the plugins in categories, but to me this looks fine.
Given the current size of the list of plugins, I honestly think that categories make it easier to navigate. However, I'm very much open to @simonbrunel take on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @simonbrunel was against putting the plugins in categories, but to me this looks fine.
I can't remember if that was actually the case (maybe there was not enough entries to justify categories).
@igorlukanin I like it organised in categories as you did (a few minor remarks).
Could have been a single new category too, or I just remember wrong 🧐 |
@kurkle @simonbrunel Should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @igorlukanin
Awesome Contribution Checklist:
Please Describe Your Addition
Following the conversation in this PR (chartjs/Chart.js#10764), I've rearranged the list of plugins by type so it's easier to navigate through it and look for relevant plugins.
@LeeLenaleee @kurkle @etimberg @simonbrunel I'd like to know what you folks think.
Also, I think we can probably remove some of barely used items from this list. Take
chartjs-plugin-waterfall
that has only 353 weekly downloads on npm.