Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange plugins by type #52

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Arrange plugins by type #52

merged 3 commits into from
Oct 21, 2022

Conversation

igorlukanin
Copy link
Member

Awesome Contribution Checklist:

  • I have read, and re-read the Contributing Guidelines
  • I have searched to ensure the suggested item doesn't exist on this list
  • This PR contains only one item

Please Describe Your Addition

Following the conversation in this PR (chartjs/Chart.js#10764), I've rearranged the list of plugins by type so it's easier to navigate through it and look for relevant plugins.

@LeeLenaleee @kurkle @etimberg @simonbrunel I'd like to know what you folks think.

Also, I think we can probably remove some of barely used items from this list. Take chartjs-plugin-waterfall that has only 353 weekly downloads on npm.

kurkle
kurkle previously approved these changes Oct 20, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @simonbrunel was against putting the plugins in categories, but to me this looks fine.

@igorlukanin
Copy link
Member Author

Given the current size of the list of plugins, I honestly think that categories make it easier to navigate. However, I'm very much open to @simonbrunel take on this.

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @simonbrunel was against putting the plugins in categories, but to me this looks fine.

I can't remember if that was actually the case (maybe there was not enough entries to justify categories).

@igorlukanin I like it organised in categories as you did (a few minor remarks).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kurkle
Copy link
Member

kurkle commented Oct 20, 2022

I can't remember if that was actually the case (maybe there was not enough entries to justify categories).

Could have been a single new category too, or I just remember wrong 🧐

@igorlukanin
Copy link
Member Author

@kurkle @simonbrunel Should be good to go now!

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @igorlukanin

@kurkle kurkle merged commit cdfdc1d into chartjs:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants