Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved quote detection and attribution #382

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improved quote detection and attribution #382

wants to merge 8 commits into from

Commits on May 1, 2023

  1. Improve quote detection by finding start and end quotation marks

    user authored and user committed May 1, 2023
    Configuration menu
    Copy the full SHA
    23abe0d View commit details
    Browse the repository at this point in the history

  2. revert some unrelated changes

    user authored and user committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e8e8971 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. added improved direct_quotations function, helper functions, constant… 

    …s and tests
    @afriedman412
    afriedman412 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    5c67017 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. updates made, tests added

    @afriedman412
    afriedman412 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1c8a8ac View commit details
    Browse the repository at this point in the history

  2. simplifying integrating linebreaks into quote detection

    @afriedman412
    afriedman412 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ff1ce50 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. final revamp

    @afriedman412
    afriedman412 committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e2568fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'chartbeat-labs:main' into dev

    @afriedman412
    afriedman412 authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5c12aa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. files formatted with black, changed code to use re instead of `rege… 

    …x` package, min_quote_length is now a `direct_quotations` parameter (not a constant), added a better example for testing linebreaks that function as closing quotes
    @afriedman412
    afriedman412 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6170a7b View commit details
    Browse the repository at this point in the history