feat!: overhaul slurmdbd charm API

Merge pull request #22 from jamesbeedy/slurm_config_editor_preparation

Summary of changes:

- remove slurm-ops-manager
- remove dead code
- emit relation data to the charm via events
- remove dependency on slurmctld
- general code cleanup
- consolidate yaml files into charmcraft.yaml
- add type tests
- rename interfaces

BREAKING CHANGES: this new API is incompatible with the old Slurm charm API. For the time being, we'll need to test the charms locally using pytest rather than the CI. The CI pulls the old API version of the Slurm charms.

.github/workflows/ci.yaml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Run tests
         uses: get-woke/woke-action@v0
         with:
@@ -34,7 +34,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install dependencies
         run: python3 -m pip install tox
       - name: Run linters
@@ -45,12 +45,23 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install dependencies
         run: python3 -m pip install tox
       - name: Run tests
         run: tox -e unit
 
+  type-check:
+    name: Type check
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Install dependencies
+        run: python3 -m pip install tox
+      - name: Run tests
+        run: tox -e type
+
   integration-test:
     strategy:
       fail-fast: true
@@ -62,10 +73,11 @@ jobs:
     needs:
       - inclusive-naming-check
       - lint
+      - type-check
       - unit-test
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup operator environment
         uses: charmed-kubernetes/actions-operator@main
         with:

.gitignore

@@ -8,3 +8,4 @@ __pycache__/
 .idea
 .vscode/
 version
+.ruff_cache/

README.md

@@ -27,10 +27,10 @@ $ juju deploy slurmd --channel edge
 $ juju deploy slurmdbd --channel edge
 $ juju deploy mysql --channel 8.0/edge
 $ juju deploy mysql-router slurmdbd-mysql-router --channel dpe/edge
-$ juju integrate slurmctld:slurmd slurmd:slurmd
+$ juju integrate slurmctld:slurmd slurmd:slurmctld
+$ juju integrate slurmctld:slurmdbd slurmdbd:slurmctld
 $ juju integrate slurmdbd-mysql-router:backend-database mysql:database
 $ juju integrate slurmdbd:database slurmdbd-mysql-router:database
-$ juju integrate slurmctld:slurmdbd slurmdbd:slurmdbd
 ```
 
 ## Project & Community

charmcraft.yaml

@@ -1,7 +1,40 @@
-# Copyright 2020 Omnivector Solutions, LLC.
+# Copyright 2020-2024 Omnivector, LLC.
 # See LICENSE file for licensing details.
-
+name: slurmdbd
 type: charm
+
+assumes:
+  - juju
+
+summary: |
+  Slurm DBD accounting daemon.
+
+description: |
+  This charm provides slurmdbd, munged, and the bindings to other utilities
+  that make lifecycle operations a breeze.
+
+  slurmdbd provides a secure enterprise-wide interface to a database for
+  SLURM. This is particularly useful for archiving accounting records.
+
+links:
+  contact: https://matrix.to/#/#hpc:ubuntu.com
+
+  source:
+    - https://github.com/omnivector-solutions/slurmdbd-operator
+
+  issues:
+    - https://github.com/omnivector-solutions/slurmdbd-operator/issues
+
+requires:
+  database:
+    interface: mysql_client
+  fluentbit:
+    interface: fluentbit
+
+provides:
+  slurmctld:
+    interface: slurmdbd
+
 bases:
   - build-on:
       - name: ubuntu
@@ -10,22 +43,3 @@ bases:
       - name: ubuntu
         channel: "22.04"
         architectures: [amd64]
-
-parts:
-  charm:
-    build-packages: [git]
-    charm-python-packages: [setuptools]
-
-  # Create a version file and pack it into the charm. This is dynamically generated
-  # as part of the build process for a charm to ensure that the git revision of the
-  # charm is always recorded in this version file.
-  version-file:
-    plugin: nil
-    build-packages:
-      - git
-    override-build: |
-      VERSION=$(git -C $CRAFT_PART_SRC/../../charm/src describe --dirty --always)
-      echo "Setting version to $VERSION"
-      echo $VERSION > $CRAFT_PART_INSTALL/version
-    stage:
-      - version