project cleanup

These changes improve the slurmdbd charm in a number of ways.

1) remove slurm-ops-manager
2) remove unused code
3) emit relation data to the charm via events
4) remove dependency on slurmctld
5) general code cleanup
6) consolidate yaml files into charmcraft.yaml
7) add type tests
8) rename interface slurmdbd -> slurmctld

.github/workflows/ci.yaml

@@ -51,6 +51,17 @@ jobs:
       - name: Run tests
         run: tox -e unit
 
+  type-check:
+    name: Mypy tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Install dependencies
+        run: python3 -m pip install tox
+      - name: Run tests
+        run: tox -e type
+
   integration-test:
     strategy:
       fail-fast: true
@@ -62,6 +73,7 @@ jobs:
     needs:
       - inclusive-naming-check
       - lint
+      - type-check
       - unit-test
     steps:
       - name: Checkout

.gitignore

@@ -8,3 +8,5 @@ __pycache__/
 .idea
 .vscode/
 version
+.ruff_cache/
+.mypy_cache/

charmcraft.yaml

@@ -1,7 +1,40 @@
-# Copyright 2020 Omnivector Solutions, LLC.
+# Copyright 2024 Omnivector, LLC.
 # See LICENSE file for licensing details.
-
+name: slurmdbd
 type: charm
+
+assumes:
+  - juju
+
+summary: |
+  Slurm DBD accounting daemon.
+
+description: |
+  This charm provides slurmdbd, munged, and the bindings to other utilities
+  that make lifecycle operations a breeze.
+
+  slurmdbd provides a secure enterprise-wide interface to a database for
+  SLURM. This is particularly useful for archiving accounting records.
+
+links:
+  contact: https://matrix.to/#/#hpc:ubuntu.com
+
+  source:
+    - https://github.com/omnivector-solutions/slurmdbd-operator
+
+  issues:
+    - https://github.com/omnivector-solutions/slurmdbd-operator/issues
+
+requires:
+  database:
+    interface: mysql_client
+  fluentbit:
+    interface: fluentbit
+
+provides:
+  slurmctld:
+    interface: slurmdbd
+
 bases:
   - build-on:
       - name: ubuntu
@@ -10,22 +43,3 @@ bases:
       - name: ubuntu
         channel: "22.04"
         architectures: [amd64]
-
-parts:
-  charm:
-    build-packages: [git]
-    charm-python-packages: [setuptools]
-
-  # Create a version file and pack it into the charm. This is dynamically generated
-  # as part of the build process for a charm to ensure that the git revision of the
-  # charm is always recorded in this version file.
-  version-file:
-    plugin: nil
-    build-packages:
-      - git
-    override-build: |
-      VERSION=$(git -C $CRAFT_PART_SRC/../../charm/src describe --dirty --always)
-      echo "Setting version to $VERSION"
-      echo $VERSION > $CRAFT_PART_INSTALL/version
-    stage:
-      - version