This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat!: overhaul slurmctld charm API #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucciTheBoss
suggested changes
Jun 19, 2024
src/interface_slurmd.py
Outdated
| partition_as_dict = json.loads(partition_as_json) | ||
| except json.JSONDecodeError as e: | ||
| logger.error(e) | ||
| raise (e) |
There was a problem hiding this comment.
Suggested change
| raise (e) | |
| raise e |
4 tasks
These changes make a number of modifications to the slurm charms. * Removes no longer used interfaces * remove slurmctld dependency on slurmdbd and slurmd * support partitions with 0 nodes * refactor relation data * recreate how configs are written * support user supplied partition configuration * start modeling config * add type checking * remove unused code * support partition events and slurmd node events * remove upgrade-charm hook as it did nothing * use systemd and apt charm libs * rename interfaces * update readme to reflect new interface names and minimal deployment using only slurmctld and slurmd * address pr feedback
NucciTheBoss
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
I'm happy to merge this pull request too. Thank you for this work @jamesbeedy 🎉
Similar to slurmdbd-operator, just going to drop .mypy_cache from .gitignore since we're now using pyright. I think this pull request is in good shape for landing the API overhaul. We can open subsequent pull requests to focus and further refine the features we need 😄
Using pyright now instead of mypy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference the Slurm Charms Change Summary Document for an in-depth explanation of these changes.
These changes make several modifications to the slurmctld charm.