feat(sackd): add sackd operator #53
Conversation
Adds a new Slurm charm for deploying sackd: the login node daemon which gets configuration files from the controller in 'configless' setups and provides support for the 'auth/slurm' authentication method.
|
IMPORTANT: We'll need to update the |
There was a problem hiding this comment.
This is a great start for your first "from scratch" charm!
I left a few comments. Overall, I think this charm is good, but it needs to be refactored to not use juju_systemd_notices to inform Juju when sackd has started or stopped. juju_systemd_notices is built to solve the issue of when we try to start the slurmd service but there's a delay between when the compute node shares its data via Juju and when it's entered into the slurm.conf configuration file on the primary control node. sackd doesn't have this problem as sackd nodes don't need to be entered into slurm.conf, so we don't need juju_systemd_notices to watch the service.
Let me know if you have any questions!
`distro` requirement from charms. `distro` is used by `slurm-ops` so kept in test requirements.
|
Looks like the release of Looking into it now but as a quick fix, hacking |
|
Added |
Should be able to revert this change now with the release of |
Yep, that's it gone now. |
|
Just one tiny nit. The commit message for a819163 is |
There was a problem hiding this comment.
LGTM with the removal of juju_systemd_notices 
I'll update the repository secret in the background while you fix the commit message for a819163. We'll worry about the interface library later when we have more time for QA work.
Great work on this!
Ah. Fixed now. |
Adds a new Slurm charm for deploying sackd: the login node daemon which gets configuration files from the controller in 'configless' setups and provides (future) support for the 'auth/slurm' authentication method.
Follows from investigation and discussion in https://github.com/orgs/charmed-hpc/discussions/11