feat(all)!: upgrade Slurm charms to Noble #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * `SackdManager` now comes with `slurm_ops` * The apt charm library now supports adding third-party repositories on noble. Signed-off-by: Jason C. Nucciarone <[email protected]>
Upgrade charms from Jammy to Noble. Key changes are that the charms now use the `base` & `platform` syntax, and the charms now use the `charm-binary-python-packages` to install rust-based packages. This helps shorten the build times from ~10 minutes to roughly ~2 minutes. Signed-off-by: Jason C. Nucciarone <[email protected]>
`mysql-router` does not yet support noble as a base so disable it in the integration tests and directly relate to the `mysql` operator. Created a generic TODO comment so it can be found in TODO tools such as PyCharm's editor. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
dsloanm
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Looks good - no problems deploying and running a test job.
I assume that stuck [email protected] CI check was fixed by 7516ce3 and can be ignored.
|
Hmm... re-running doesn't seem to refresh the state, so I might need to manipulate the branch protection rules for a hot second. |
|
+1 Nice!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the Slurm charms to Noble from Jammy. We get several benefits from this such as access to a newer base and package versions + more recent hardware support.
BREAKING CHANGES:
ppa:ubuntu-hpc/slurm-wlm-23.02to install Slurm. Instead Slurm is pulled directly from the Ubuntu Archive. This enables us to use Slurm 23.11. Newer versions of Slurm should be published to the experimental PPAppa:ubuntu-hpc/experimentalrather than create a separate PPA for the Slurm packages.charm-binary-python-paclagesdirective in charmcraft.yaml. This pulls in pre-built versions of Rust-based packages such ascryptographyandpydanticrather than compile them from source withrustc. This should drastically reduce the amount of time it takes to run integration tests.mysql-routerin the integration test suite. Themysql-routersubordinate charm does not yet support Noble, so instead we integrate directly with themysqlcharm in the integration tests.mysql-routersupporting Noble will likely not come until after the 25.04 cycle.base,platformssyntax that was introduced with charmcraft v3 for charms that support[email protected]and greater.