Skip to content

Commit

Permalink
fix(slurmctld): remove shlex.split from _resume_nodes
Browse files Browse the repository at this point in the history
  • Loading branch information
dsloanm authored and NucciTheBoss committed Dec 9, 2024
1 parent 3d8240d commit 9e38e3a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions charms/slurmctld/src/charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,7 @@ def get_jwt_rsa(self) -> Optional[str]:

def _resume_nodes(self, nodelist: List[str]) -> None:
"""Run scontrol to resume the specified node list."""
nodes = ",".join(nodelist)
update_cmd = f"update nodename={nodes} state=resume"
self._slurmctld.scontrol(*shlex.split(update_cmd))
self._slurmctld.scontrol("update", f"nodename={','.join(nodelist)}", "state=resume")

@property
def _cluster_name(self) -> str:
Expand Down

0 comments on commit 9e38e3a

Please sign in to comment.