Skip to content

Commit

Permalink
fix(ci): do not use destructive packing when building charms for release
Browse files Browse the repository at this point in the history
Sets the `destructive-mode` option for the `upload-charm` action to false.
Pulling the down the base LXD instance will add some extra time onto the
workflow run, but it make us not be dependent on the base OS of the
GitHub runner VM.

Eventually we'll either want to replace the `cryptography` dependency
that takes so long to build, or use the `ccc` tool to cache the Slurm
charms dependencies so that the build for them is quicker.

Signed-off-by: Jason C. Nucciarone <[email protected]>
  • Loading branch information
NucciTheBoss authored and wolsen committed Nov 22, 2024
1 parent 569272e commit 84615ce
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@ jobs:
channel: "${{ steps.channel.outputs.name }}"
charm-path: "./_build/${{ matrix.charm }}"
tag-prefix: "${{ matrix.charm }}"
destructive-mode: false

0 comments on commit 84615ce

Please sign in to comment.