feat(slurm_ops): add gres.conf configuration file editor to SlurmctldManager
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: * Reordered configuration manager classes to be in alphabetical order. * Bump the API version of slurmutils being pulled to 0.10. Signed-off-by: Jason C. Nucciarone <[email protected]>
Other changes: * Add unit tests for new gres.conf editor on `SlurmctldManager`. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a gres.conf editor to
SlurmctldManagerso that we can configure GPUs in Charmed HPC through the gres.conf file. Generic resources need to be declared in gres.conf so that we can then declare nodes that have these resources within slurm.conf.Misc.
slurm_opsunit tests by moving test cases into their own files. test_slurm_ops.py was starting to become quite big so I broke tests down by focus area. Operations, package management, configuration management, etc._ConfigManagerchild classes to be in alphabetical order, so it makes the git diff appear larger that it actually is 😅