feat(slurm_ops): add acct_gather.conf configuration file editor to SlurmctldManager
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
dsloanm
approved these changes
Dec 5, 2024
| contents=EXAMPLE_ACCT_GATHER_CONFIG, | ||
| ) | ||
|
|
||
| def test_config(self) -> None: |
There was a problem hiding this comment.
Might be cleaner to split this into multiple tests. There's a lot of asserts in this function.
There was a problem hiding this comment.
I have it like this as slurmutils should be responsible for testing the nitty gritty of each editor/model with individual test functions. These unit tests are more or less for testing that we don't break the API for managing Slurm configs with slurm_ops.
If anything, we could probably make the tests shorter. The only thing is that we still have to be clever with mocking the uid and gid of the file as pyfakes doesn't provide any abstractions for doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an attribute for managing the acct_gather.conf configuration file to the
SlurmctldManagerclass. This attribute can then be used to handle changes related to configuring an acct_gather plugin from within the slurmctld charm. Having the editor be available will be necessary for re-enabling InfluxDB support in the Slurm charms.Bumps the version of
slurm_opsto 0.9.