fix(slurm_ops): implement feedback from slurm-charms PR #35 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: José Julián Espina <[email protected]>
…rm nodes Only the `slurmd` package creates `/var/lib/slurm/checkpoint` upon installation, so the method `charms.hpc_libs.v0.slurm_ops._AptManager._create_state_save_location` ensures that the directory is created on all nodes, and owned by the Slurm user. Signed-off-by: Jason C. Nucciarone <[email protected]>
…s` as deps Signed-off-by: Jason C. Nucciarone <[email protected]>
Maps to the correct service name as installed by the `munge` Debian package. Signed-off-by: Jason C. Nucciarone <[email protected]>
Use private `_call` function to create the slurmrestd user and group as the command will be logged, and it proper casts the gid and uid to string. `subprocess.check_output` will raise a `TypeError`. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Adds additional test as well to ensure that `/var/lib/slurm` has the correct file permissions mode if created by the `charms.hpc_libs.v0.slurm_ops._AptManager._create_state_save_location` method after the relevant Slurm daemon has been installed. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary fixes needed for
slurm_opsto unblock charmed-hpc/slurm-charms#35. The PR also bumps theLIBPATCHversion to8.Related issues
libslurmfull.somissing after installingslurmrestdservice #52/etc/slurmdirectory must be created manually after installingslurmrestd#51slurmrestdservice #50StateSaveLocationfile permissions are too restrictive #49_apply_overridesraises an error when creating theslurmrestduser and group #48_AptManager#47/var/lib/slurmdirectory #46