feat(slurm_ops): add cgroup configuration manager #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Changes: - Add configuration manager for cgroup.conf on `SlurmctldManager`. This is required to reach feature parity with `slurmctld_ops` Signed-off-by: Jason C. Nucciarone <[email protected]>
…interface Chnages: - Add unit tests for the cgroup.conf configuration manager. Signed-off-by: Jason C. Nucciarone <[email protected]>
…anager interface Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the configuration management interface and adds a configuration manager for the cgroup.conf file. The configuration management interface is extended by adding the
loadanddumpmethods which make it much easier to build abstractions around the various configuration files on the machines.Also includes some various quality of life fixes such as removing a random string that we had in the integration tests, minor documentation and formatting fixes here and there.
Closes #31