feat(slurm_ops): add scontrol and clean up public exports
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now intend that you directly call the manager that you plan on using rather than compose it yourself within the specific Slurm charm. This commit makes the methods and classes that we want private have a underscore before their name so that it is more obvious that it isn't intended to be a publicly used object outside of the charm library. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Sep 18, 2024
Yes, it will be quite nice. The abstraction of deb vs snap is excellent 🤩 Will hold off on vbump since I still need to introduce some stuff to help with managing the cgroup configurations, but I'll still merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the static method
scontrolto_SlurmManagerBase, and it cleans up the public exports of the slurm_ops charm library to just beSlurmctldManager,SlurmdManager,SlurmdbdManager,SlurmrestdManager, andSlurmOpsError.Closes #29