Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove decode inside _call #21

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jedel1043
Copy link
Contributor

Fixes a bug where the script would throw when check_output throws an error, since the returned stderr would be a str instead of bytes.

@NucciTheBoss NucciTheBoss self-requested a review July 26, 2024 21:13
@jedel1043 jedel1043 closed this Sep 10, 2024
Fixes a bug where the script would throw when `check_output` throws an error, since the returned `stderr` would be a str instead of bytes.
@jedel1043 jedel1043 reopened this Sep 10, 2024
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@NucciTheBoss NucciTheBoss merged commit 4e5e870 into charmed-hpc:main Sep 10, 2024
8 checks passed
@jedel1043 jedel1043 deleted the fix-call-text-mode branch September 10, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants