Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to get the host name #17

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

jedel1043
Copy link
Contributor

Closes #16.

@jedel1043
Copy link
Contributor Author

Should be merged after #15 to avoid bumping the version number twice.

@NucciTheBoss NucciTheBoss self-requested a review July 12, 2024 20:18
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it 🚢

@NucciTheBoss NucciTheBoss merged commit b72ce34 into charmed-hpc:main Jul 12, 2024
4 checks passed
@jedel1043 jedel1043 deleted the get-host-name branch July 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add hostname method to SlurmManagerBase
2 participants