Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce cryptographic documentation #11

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jedel1043
Copy link
Contributor

Documents all our current key generation algorithms.

@jedel1043 jedel1043 added the documentation Improvements or additions to documentation label Oct 16, 2024
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. I like how in-depth you went with the documentation.

Just one small nit that I'd like your thoughts on and then I'm ready to merge & ship :shipit:

explanation/cryptography/index.md Outdated Show resolved Hide resolved
Documents all our current key generation algorithms.
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NucciTheBoss NucciTheBoss merged commit 3ce36ab into charmed-hpc:main Oct 17, 2024
1 check passed
@jedel1043 jedel1043 deleted the crypto-docs branch October 17, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants