Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow functions that return strings for output #16

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

timteeee
Copy link
Contributor

When copying the suggested config in the readme, I found a bug with the open_by_os function where it was passing the output to vim.fn.expand which expects a string. The suggested config in the readme is actually a function that returns a string, resulting in the following error:

image

This fix allows for output to be either a string or a function that returns a string, in order to support the suggested config in the readme.

@isabelroses isabelroses merged commit 0025c3a into charm-and-friends:main Nov 14, 2024
3 checks passed
@isabelroses
Copy link
Member

Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants